* Rajendra Nayak <rnayak@xxxxxx> [111114 19:40]:
> On Tuesday 15 November 2011 03:00 AM, Tony Lindgren wrote:
> >* Rajendra Nayak<rnayak@xxxxxx> [111104 04:16]:
> >>@@ -1869,6 +1957,14 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev)
> >> struct omap_hsmmc_host *host = NULL;
> >> struct resource *res;
> >> int ret, irq;
> >>+ const struct of_device_id *match;
> >>+
> >>+ match = of_match_device(omap_mmc_of_match,&pdev->dev);
> >>+ if (match) {
> >>+ pdata = of_get_hsmmc_pdata(&pdev->dev);
> >>+ if (match->data)
> >>+ pdata->reg_offset = *(u16 *)match->data;
> >>+ }
> >
> >So this is now using both DT and pdata?
> >
> >We want to use DT only, and get rid of pdata. Other than the
> >deferred probe, is there some other dependency remaining to
> >having to use the pdata also?
>
> We are using pdata today mainly for the platform function pointers
> that get passed for MMC, which can never be passed from DT.
>
> The omap_mmc_platform_data structure today has '17' function pointers.
> Most might be sparingly used, nevertheless, its an awfully large number.
Yeah OK.
> Here's the list...
> ---------
> int (*switch_slot)(struct device *dev, int slot);
> int (*init)(struct device *dev);
> void (*cleanup)(struct device *dev);
> void (*shutdown)(struct device *dev);
> int (*suspend)(struct device *dev, int slot);
> int (*resume)(struct device *dev, int slot);
> int (*get_context_loss_count)(struct device *dev);
>
> per-slot functions
>
> int (*set_bus_mode)(struct device *dev, int slot, int bus_mode);
> int (*set_power)(struct device *dev, int slot,
> int power_on, int vdd);
> int (*get_ro)(struct device *dev, int slot);
> int (*set_sleep)(struct device *dev, int slot, int sleep,
> int vdd, int cardsleep);
> void (*remux)(struct device *dev, int slot, int power_on);
> void (*before_set_reg)(struct device *dev, int slot,
> int power_on, int vdd);
> void (*after_set_reg)(struct device *dev, int slot,
> int power_on, int vdd);
> void (*init_card)(struct mmc_card *card);
> int (*get_cover_state)(struct device *dev, int slot);
> int (*card_detect)(struct device *dev, int slot);
> ---------
To me it seems we should move these into drivers/mmc/host/omap_hsmmc.c
and set them based on DT compatible (or some other) property.
If these functions tinker with some internal registers, then we need
to fix those too to use regulator/gpio API.
This way we don't need the platform_data any longer.
Regards,
Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
