On Wednesday 16 November 2011, Shashidhar Hiremath wrote: > The patch provides An infrastructure to test commands other than Read/Write commands using the IOCTL interface.The Patch can be useful incase of validating the device to verify whether device support a given command or not. The result of the sent command will be written to the result element of the mmc_ioc_cmd structure passed through IOCTL interface. > > Signed-off-by: Shashidhar Hiremath <shashidharh@xxxxxxxxxxxxxxx> Hi Shashidhar, Unfortunately, I have to tell you that an implementation like this is inappropriate for a number of reasons. My feeling is that most importantly you should instead have the test logic entirely in user space and only call the existing ioctl in the kernel. This would make the entire patch obsolete, so I'm not commenting on the other problems. What has lead you to implementing the individual test cases in the kernel? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
