On Tue, Oct 25, 2011 at 1:43 PM, Sebastian Rasmussen <sebras@xxxxxxxxx> wrote: >[Giuseppe] >> This patch enhances the debug information reported >> for the mmc card by parsing the extended CSD registers >> obviously according to all the current specifications. > > Does this belong kernel or in userspace? I'm not sure, and > I'm hoping that any of the old-timers here chime in on it. > Anyway I supply you with a few comments on you patch > below... Since it's in debugfs we can have it as verbose and whatever weird structure we wish. Userspace tools usually don't depend on debugfs ... except for some :-/ (see recent ftrace vs perf debates etc etc) To implement getting at this data in a future-proof way from userspace we should put it in sysfs. And if it was in sysfs we would have to follow the rule "one value per file" with files named after each CSD/etc field. Then to make that human-readable you would need a userspace tool, and preferrably it should also be documented in Documentation/ABI/testing/* And nothing really prevents us from doing both :-) Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
