Re: [PATCH] mmc: sdhci-pci: move suspend/resume hooks to dev_pm_ops

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Adrian,

On Wed, Nov 2, 2011 at 10:45 AM, Adrian Hunter <adrian.hunter@xxxxxxxxx> wrote:
> On 01/11/11 14:34, Manuel Lauss wrote:
>> Move suspend/resume/freeze/thaw hooks from struct pci_driver to dev_pm_ops,
>> mainly to shut up the driver cores' complaints about this driver using
>> both new and legacy PM methods.

[...]

>> +static int sdhci_pci_suspend(struct device *dev)
>> +{
>> +     struct pci_dev *pdev = container_of(dev, struct pci_dev, dev);
>> +     return sdhci_pci_do_suspend(pdev, PMSG_SUSPEND);
>
> We need to get rid of state entirely.  Unfortunately that means
> changing sdhci_suspend_host() and all callers

This first attempt was a quick hack to get rid of the annoying messages.
I'll cook up something more thorough, hang on.

Thanks!
      Manuel Lauss
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux