On 27 October 2011 01:23, Chris Ball <cjb@xxxxxxxxxx> wrote: > Hi Girish, > > On Wed, Oct 26 2011, Girish K S wrote: >> This patch adds the support of the HS200 bus speed for eMMC 4.5 devices. >> The eMMC 4.5 devices have support for 200MHz bus speed.The mmc core and >> host modules have been touched to add support for this module. >> >> It is necessary to know the card type in the sdhci.c file to add support >> for eMMC tuning function. So card.h file is included to import the card >> data structure. >> >> cc: Chris Ball <cjb@xxxxxxxxxx> >> Signed-off-by: Girish K S <girish.shivananjappa@xxxxxxxxxx> > > The long case statements and conditionals in this patch make it pretty > dense/ugly -- can you think of a way to avoid doing this to the code? Definitely will workout. > Also, it would be good to hear if anyone else has tested/is using this > patch. > > Is having a new mmc_card_hs200() test desirable, compared to just > reusing mmc_card_highspeed() and checking the ext_csd.card_type? The specification classifies from 26 to 52MHz as high speed. And anything above it upto 200 as hs200. I added the macro for clarity and to be inclined to the specification. > Thanks, > > - Chris. > -- > Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> > One Laptop Per Child > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
