2011/10/12 Randy Dunlap <rdunlap@xxxxxxxxxxxx>: > On 10/11/11 12:31, Andrei Warkentin wrote: >> Hi Randy, >> >> ----- Original Message ----- >>> From: "Randy Dunlap" <rdunlap@xxxxxxxxxxxx> >>> To: "Stephen Rothwell" <sfr@xxxxxxxxxxxxxxxx> >>> Cc: linux-next@xxxxxxxxxxxxxxx, "LKML" <linux-kernel@xxxxxxxxxxxxxxx>, linux-mmc@xxxxxxxxxxxxxxx, "Chris Ball" >>> <cjb@xxxxxxxxxx> >>> Sent: Tuesday, October 11, 2011 2:49:39 PM >>> Subject: Re: linux-next: Tree for Oct 11 (mmc) >>> >>> On 10/11/11 02:11, Stephen Rothwell wrote: >>>> Hi all, >>>> >>>> The linux-next tree is now available from >>>> git://github.com/sfrothwell/linux-next.git as a temporary measure >>>> while >>>> the kernel.org servers are unavailable. >>>> >>>> It may also turn up on git.kernel.org (depending on the mirroring). >>>> The >>>> patch set is still absent, however. >>>> >>>> Changes since 20111007: >>> >>> >>> When CONFIG_BLOCK is not enabled: >>> >>> In file included from >>> next-2011-1011/drivers/mmc/card/sdio_uart.c:43:0: >>> next-2011-1011/include/linux/mmc/card.h:175:12: error: >>> 'DISK_NAME_LEN' undeclared here (not in a function) >>> >>> Deleting the #include <linux/mmc/card.h> fixes the sdio_uart.c build. >>> However, the same problem occurs in mmc/core/core.c: >>> >> >> Because linux/genhd is now included, oops. I'm pretty positive this is due to the "mmc : general purpose partition support" patch pulled recently. I am adding NamJae, who was the author. >> >>> In file included from next-2011-1011/drivers/mmc/core/core.c:30:0: >>> next-2011-1011/include/linux/mmc/card.h:175:12: error: >>> 'DISK_NAME_LEN' undeclared here (not in a function) >>> >>> Should mmc/core/ depend on BLOCK? or should it just be made >>> to build even when BLOCK is not enabled? >>> >> >> I don't think there should be a direct dependency on BLOCK. I have two suggestions - >> 1) Have our own define similar to (and in fact smaller): >> linux/genhd.h:#define DISK_NAME_LEN 32 >> 2) Put the MMC physical partition code under an #ifdef CONFIG_BLOCK, which is a reasonable >> proposition, given that there wouldn't be any need to parse physical partition info if >> it would never be consumed by the MMC block driver. >> >> Thoughts? > > Agreed on part 2). Do part 1) if it is required, but it's usually better > not to duplicate constants or structs etc. > IOW, can DISK_NAME_LEN in linux/genhd.h be exposed even when CONFIG_BLOCK > is not enabled? Hi Randy, Andrei. I suggest third option for this. As you know, MMC like ATA Driver and SCSI Driver etc.. can not enable without CONFIG_BLOCK So I think that mmc should be depended from CONFIG_BLOCK like other block device driver. see the their Kconfig. How do you think ? -------------------------------------------------------------------------------------------------------------------------------- menuconfig ATA tristate "Serial ATA and Parallel ATA drivers" depends on HAS_IOMEM depends on BLOCK depends on !(M32R || M68K) || BROKEN config SCSI tristate "SCSI device support" depends on BLOCK select SCSI_DMA if HAS_DMA ---help--- --------------------------------------------------------------------------------------------------------------------- > > > -- > ~Randy > *** Remember to use Documentation/SubmitChecklist when testing your code *** > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html