Hi, On Wed, Oct 05 2011, Ulf Hansson wrote: > Adrian Hunter wrote: >> mmc_request_done() is sometimes called from interrupt >> or other atomic context. Mostly all mmc_request_done() >> does is complete(), however it contains code to retry >> on error, which uses ->request(). As the error path >> is certainly not performance critical, this may be >> moved to the waiting function mmc_wait_for_req_done(). >> >> This allows ->request() to use runtime PM get_sync() >> and guarantee it is never in an atomic context. >> >> Signed-off-by: Adrian Hunter <adrian.hunter@xxxxxxxxx> > > Calling back into the host driver directly from mmc_request_done when > doing error handling were just plain wrong. > > This patch is really great, not just for pm_runtime issues! > > Acked-by: Ulf Hansson <ulf.hansson@xxxxxxxxxxxxxx> Pushed to mmc-next for 3.2. Thanks! - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
