Re: [PATCH 4/4] mmc: mmci: Fix incorrect handling of HW flow control for SDIO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Russel,

On 10/01/2011 06:12 PM, Russell King - ARM Linux wrote:
Shouldn't this also re-enable the ST hardware flow control for non-SDIO
cards?

I do not think that is needed. Hardware flow control is turned on per default for all cards thanks to the .clkreg member of the variant struct:

	mmci_set_clkreg():
		clk |= variant->clkreg_enable;
where
	static struct variant_data variant_ux500v2 = {
		.clkreg_enable          = MCI_ST_UX500_HWFCEN,

This means that HWFC will be on for all cards. This patch only disables it for SDIO cards (thanks to the mmc_card_sdio()-check) during problematic transfers (HW peculiarity), and then re-enables it again for SDIO cards during "normal" transfers. So the HWFC state for non-SDIO cards should not be touched I think.

Best Regards

Stefan Nilsson
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux