Re: [PATCH] mmc: dw_mmc: add write/read function for DATA register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi James.

> Can I suggest that instead of having 6 new macros with offset parameters
> from the reg parameter (after all, the caller can just add the offset to
> the reg argument just as easily), you simply store the data register
> offset (what is currently DATA+host->data_offset) instead of
> host->data_offset, and use that instead of DATA. That would be simpler
> and more readable.


Sure..i understood your suggestion. But i think that need check the
version-id. i will also consider more..:)

> 
> DATA should probably be defined as the most up to date value, and define
> another one for pre-240A versions.


Right. i wonder why changed the DATA register :(

Best Regards,
Jaehoon Chung
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux