Re: [PATCH] mmc: dw_mmc: fix wrong SDMMC_GET_FCNT macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/26/2011 06:41 AM, Jaehoon Chung wrote:
> I understood that SDMMC_GET_FCNT is used to get fifo_count.
> In status register, fifo_count is bit[17:29].
> But this macro is control with bit[17:25].
> 
> i think right that change 0x1FFF instead of 0x1FF.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> Signed-off-by: Kyungmin Park <kyungmin.Park@xxxxxxxxxxx>

nice catch.

Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx>

> ---
>  drivers/mmc/host/dw_mmc.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index bfa3c1c..193ec94 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -117,7 +117,7 @@
>  #define SDMMC_CMD_RESP_EXP		BIT(6)
>  #define SDMMC_CMD_INDX(n)		((n) & 0x1F)
>  /* Status register defines */
> -#define SDMMC_GET_FCNT(x)		(((x)>>17) & 0x1FF)
> +#define SDMMC_GET_FCNT(x)		(((x)>>17) & 0x1FFF)
>  /* Internal DMAC interrupt defines */
>  #define SDMMC_IDMAC_INT_AI		BIT(9)
>  #define SDMMC_IDMAC_INT_NI		BIT(8)

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux