Re: [PATCH] MMC: ext_csd.raw_* used in comparison but never set

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Acked-by: Philip Rakity <prakity@xxxxxxxxxxx>

On Sep 22, 2011, at 9:25 PM, Andrei Warkentin wrote:

> f39b2dd9d065151a04f5996656d1f27a7eb32d45 added code to
> only compare read-only ext_csd fields in bus width
> testing code, yet it's comparing some fields that are
> never set.
> 
> The affected fields are ext_csd.raw_erased_mem_count and
> ext_csd.raw_partition_support.
> 
> Signed-off-by: Andrei Warkentin <andrey.warkentin@xxxxxxxxx>
> ---
> drivers/mmc/core/mmc.c |    2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 5700b1c..bb33832 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -359,6 +359,7 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
> 		 * card has the Enhanced area enabled.  If so, export enhanced
> 		 * area offset and size to user by adding sysfs interface.
> 		 */
> +		card->ext_csd.raw_partition_support = ext_csd[EXT_CSD_PARTITION_SUPPORT];
> 		if ((ext_csd[EXT_CSD_PARTITION_SUPPORT] & 0x2) &&
> 		    (ext_csd[EXT_CSD_PARTITION_ATTRIBUTE] & 0x1)) {
> 			u8 hc_erase_grp_sz =
> @@ -405,6 +406,7 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
> 	if (card->ext_csd.rev >= 5)
> 		card->ext_csd.rel_param = ext_csd[EXT_CSD_WR_REL_PARAM];
> 
> +	card->ext_csd.raw_erased_mem_count = ext_csd[EXT_CSD_ERASED_MEM_CONT];
> 	if (ext_csd[EXT_CSD_ERASED_MEM_CONT])
> 		card->erased_byte = 0xFF;
> 	else
> -- 
> 1.7.6.1
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux