Hi Ulf, I'm not familiar with mmc, but I've some questions on sd below. On Thu, Sep 15, 2011 at 05:50:38PM +0200, Ulf Hansson wrote: > Earlier all cards where initiated with bus mode set as OPENDRAIN, and then > later switched to PUSHPULL. According to the MMC/SD/SDIO specifications only > MMC cards use OPENDRAIN during init. For both SD and SDIO the bus mode shall > be PUSHPULL before attempting to init the card. AFAIK, there is no open drain mode in sd, and the sd host controller actually does not care about this setting(sdhci_set_ios does not manipulate bus_mode stored in ios). > > The consequence of having incorrect bus mode can lead to not being able > to detect the card. Therefore the default behavior have now been changed to > PUSHPULL in mmc_power_up, and will only be temporarily switched when trying > to attach or init a MMC card. Do you see any sd cards that failed to be detected due to the incorrect bus_mode setting? Anyway, your patch removed an unnecessary call to mmc_set_bus_mode which should have no effect if the underlying controller is sdhci. -Aaron -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
