Re: [PATCH] mmc: add a short delay in mmc_power_off

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 7, 2011 at 10:03 PM, Daniel Drake <dsd@xxxxxxxxxx> wrote:
>> Adding random sleeps without understanding what exactly do they solve
>> generally feels wrong...
>
> Well, if you remove the existing sleeps from mmc_power_up do things
> keep working for you?

I wouldn't call them random - they're pretty much explained.

OTOH, the delay you're suggesting to add isn't: we don't know what is
it solving exactly and why is it needed.

IMHO mainline kernel code should be well explained, otherwise it'd
become impossible to maintain.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux