Re: [PATCH] dw_mmc: ensure the ciu-reset

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Will

Will Newton wrote:

> On Mon, Sep 5, 2011 at 1:39 AM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote:
> 
> Hi Jaehoon,
> 
>> This patch ensured the CIU-reset.
>>
>> If data0 line is low, bit[9] in status register is set to 1.
>> Then we can know the card is busy.
>>
>> Using this bit in status register, we can ensure to reset the CIU correctly.
>> When card is busy and doing ciu-reset, seem like reset completed.
>> But actually didn't complete ciu-reset. because card is busy.
>>
>> So i think good whether check card busy or not before reset the ciu.
> 
> It looks like this isn't exactly what the patch does - the reset
> happens whether the card is busy or not, but if card data is busy then
> the reset may be re-issued.

the reset is happen regardless of the card is busy or not.
Maybe looks like the reset is completed. and no more issued the reset.
But when card is bus and reset completed, maybe next sequence didn't run.
(next sequence is maybe CMD0 issued)
This patch should be prevent not to run next sequence.

> 
> Is there some way to reproduce the issue in this patch? I can't find
> anything in the TRM that suggests that we need to issue the reset more
> than once.


i think this problem is similar to Software/Hardware restrictions.
(in spec, mentioned that have to check the bit[9] in status register before clock change)
Also in this case, to ensure that card is correctly running,
i think that need the more reset processing than once.

in the most case, maybe card status is not busy. then perform to reset only one-time

Best regards,
Jaehoon Chung

> Thanks,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux