Re: [PATCH 3/3 v2] mmc: Use mmc_delay() instead of mdelay() for time delay

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Aug 26, 2011, at 2:55 AM, Chunhe Lan wrote:

> The mmc_delay() is a wrapper function for mdelay() and msleep().
> 
>    o mdelay() -- block the system when busy-waiting.
>    o msleep() -- suspend the currently running task to enable CPU
>                  to process other tasks, so it is non-blocking
>                  regarding the whole system.
> 
> When the desired delay time is more than a period of timer interrupt,
> just use msleep(). Change mdelay() to mmc_delay() to avoid chewing
> CPU when busy wait.
> 
> Signed-off-by: Shengzhou Liu <b36685@xxxxxxxxxxxxx>
> Signed-off-by: Chunhe Lan <Chunhe.Lan@xxxxxxxxxxxxx>
> Cc: Chris Ball <cjb@xxxxxxxxxx>
> ---
> drivers/mmc/host/sdhci.c |   10 +++++-----
> 1 files changed, 5 insertions(+), 5 deletions(-)

It might be good to either merge patch 2/3 & 3/3 or rename them since they have same commit message.

Chris,

Any comments on closing on these patches?

- k
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux