On Fri, Aug 26, 2011 at 10:42:39AM +0200, Guennadi Liakhovetski wrote: > From: Simon Horman <horms@xxxxxxxxxxxx> > > Allow named IRQs to use corresponding specific handlers. If named IRQs are > used, at least an "sdcard" IRQ has to be specified by the platform. If > names are not used, an arbitrary number of IRQs can be provided by the > platform, in which case the generic ISR will be used for each of them. > > Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > Acked-by: Magnus Damm <magnus.damm@xxxxxxxxx> > Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx> > [g.liakhovetski@xxxxxx: style and typo corrections, platform data check] > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx> > --- > > Simon, this is what I propose to commit. I fixed a typo, wrong multi-line > comment style and indentation spaces in your patch. Besides, I added a > check to require the SDCARD IRQ if named IRQs are used. It is a common > practice to verify platform data availability and at least some basic > correctness and completeness. This check is trivial and adds extra > robustness to the driver. Please, have a look, whether you agree with my > version. Hi Guennadi, thanks, this looks fine to me. I would prefer slightly if SDCARD wasn't required. But I think that is a discussion that we can have if/when a use-case arises. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
