On Thu, 25 Aug 2011 18:23:35 +0800, Kyungmin Park <kmpark@xxxxxxxxxxxxx>
wrote:
On Thu, Aug 25, 2011 at 5:54 PM, Chunhe Lan <Chunhe.Lan@xxxxxxxxxxxxx>
wrote:
The mmc_delay() is a wrapper function for mdelay() and msleep().
o mdelay() -- block the system when busy-waiting.
o msleep() -- suspend the currently running task to enable CPU
to process other tasks, so it is non-blocking
regarding the whole system.
When the desired delay time is more than a period of timer interrupt,
just use msleep(). Change mdelay() to mmc_delay() to avoid chewing
CPU when busy wait.
Signed-off-by: Shengzhou Liu <b36685@xxxxxxxxxxxxx>
Signed-off-by: Chunhe Lan <Chunhe.Lan@xxxxxxxxxxxxx>
Cc: Chris Ball <cjb@xxxxxxxxxx>
---
drivers/mmc/host/sdhci.c | 11 ++++++-----
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 0e02cc1..0cb5dc1 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -27,6 +27,7 @@
#include <linux/mmc/host.h>
#include "sdhci.h"
+#include "../core/core.h"
Doesn't better to move the mmc_delay() to "include/linux/mmc/core.h"?
and include it.
I think It's not proper include syntax using relative path.
Yes, your suggestion is very good.
I will move the mmc_delay() to "include/linux/mmc/core.h" .
Thanks.
-Jack Lan
Thank you,
Kyungmin Park
#define DRIVER_NAME "sdhci"
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
