RFC : mmc : Use wait_for_completion_timeout() instead of wait_for_completion in case of multiple write blocks.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi.

If card is infinitely holding pull down busy line(data 0) while
writing multiple blocks, write will be blocked in
mmc_wait_for_req_done().
I suggest to use wait_for_completion_timeout instread of
wait_for_completion like the below code.

How do you think about my suggestion ?

Thanks.

------------------------------------------------------------------------------------------------------------------
static void mmc_wait_for_req_done(struct mmc_host *host, struct
mmc_request *mrq)
{
        unsigned int write_timeout = 0;
	
        if(mrq->data != NULL && (mrq->data->flags & MMC_DATA_WRITE) &&
(mrq->cmd->opcode & MMC_WRITE_MULTIPLE_BLOCK)) {
                write_timeout =
usecs_to_jiffies(mrq->data->timeout_ns/1000) * mrq->data->blocks;
                wait_for_completion_timeout(&mrq->completion, write_timeout);
        }
        else wait_for_completion(&mrq->completion);
}
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux