Re: [PATCH 3/5] mmc: sdhi: Add defines for platform irq indexes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 16 Aug 2011, Simon Horman wrote:

> This is intended to make it easier to correctly
> order platform defines in platform data and
> the logic that uses them.
> 
> Cc: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> Cc: Magnus Damm <magnus.damm@xxxxxxxxx>
> Cc: Paul Mundt <lethal@xxxxxxxxxxxx>
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> ---
>  include/linux/mmc/sh_mobile_sdhi.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/mmc/sh_mobile_sdhi.h b/include/linux/mmc/sh_mobile_sdhi.h
> index bd50b36..c66c58c 100644
> --- a/include/linux/mmc/sh_mobile_sdhi.h
> +++ b/include/linux/mmc/sh_mobile_sdhi.h
> @@ -3,6 +3,10 @@
>  
>  #include <linux/types.h>
>  
> +#define SH_MOBILE_SDHI_IRQ_SDCARD	0
> +#define SH_MOBILE_SDHI_IRQ_CARD_DETECT	1
> +#define SH_MOBILE_SDHI_IRQ_SDIO		2
> +

An idea: make this an enum, put SH_MOBILE_SDHI_IRQ_NUMBER as a last item 
and use it in sh_mobile_sdhi_remove() as

	for (i = 0; i < SH_MOBILE_SDHI_IRQ_NUMBER; i++) {

? I would also merge it with PATCH 4/5.

>  struct platform_device;
>  struct tmio_mmc_data;
>  
> -- 
> 1.7.5.4

Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux