On Mon, Jul 04, 2011 at 12:25:48AM -0600, Grant Likely wrote: > On Sun, Jul 03, 2011 at 04:30:51PM +0800, Shawn Guo wrote: > > The patch adds device tree probe support for sdhci-esdhc-imx driver. > > > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxx> > > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > > Cc: Chris Ball <cjb@xxxxxxxxxx> > > Cc: Grant Likely <grant.likely@xxxxxxxxxxxx> > > --- > > .../devicetree/bindings/mmc/fsl-imx-esdhc.txt | 40 ++++++++ > > drivers/mmc/host/sdhci-esdhc-imx.c | 99 +++++++++++++++++++- > > 2 files changed, 134 insertions(+), 5 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > > > > diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > > new file mode 100644 > > index 0000000..e182e7c > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.txt > > @@ -0,0 +1,40 @@ > > +* Freescale Enhanced Secure Digital Host Controller (eSDHC) for i.MX > > + > > +The Enhanced Secure Digital Host Controller on Freescale i.MX family > > +provides an interface for MMC, SD, and SDIO types of memory cards. > > + > > +Required properties: > > +- compatible : Should be "fsl,<chip>-esdhc" > > +- reg : Should contain eSDHC registers location and length > > +- interrupts : Should contain eSDHC interrupt > > +- cd-type : String, card detection (CD) method. Supported values are: > > Similar to previous comments, use the "fsl," prefix to this property name. > I did not know even property name could be written like this. I tried it and found it works :) > > + "none" : No CD > > + "controller" : Uses eSDHC controller internal CD signal > > + "gpio" : Uses GPIO pin for CD > > I would say the presence of a "cd-gpios" property would implicitly > mean gpio is to be used for the CD pin. > Yes, you are right. But I would say this is a direct translation of the existing platform_data. After all, we are sharing most of code path between platform and dt. -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
