Hi Ohad, On Sun, Jun 26 2011, Ohad Ben-Cohen wrote: > On Fri, Jun 10, 2011 at 2:40 AM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote: >> After commit e1866b3 "PM / Runtime: Rework runtime PM handling >> during driver removal" was introduced, the driver core stopped >> incrementing the runtime PM usage counter of the device during >> the invocation of the ->remove() callback. >> >> This indirectly broke SDIO's runtime PM path during driver removal, >> because no one calls _put_sync() anymore after ->remove() completes. >> >> This means that the power of runtime-PM-managed SDIO cards is kept >> high after their driver is removed (even if it was powered down >> beforehand). >> >> Fix that by directly calling _put_sync() when the last usage >> counter is downref'ed by the SDIO bus. > > Can you please take this 1-liner into 3.0-rc ? > > It fixes SDIO runtime PM after a breakage was introduced in 3.0. Merged, thanks. I'll be sending a pull request on my for-linus branch shortly: http://git.kernel.org/?p=linux/kernel/git/cjb/mmc.git;a=shortlog;h=refs/heads/for-linus - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html