On Wed, Jun 22, 2011 at 11:56 PM, Kevin Hilman <khilman@xxxxxx> wrote: > Balaji T K <balajitk@xxxxxx> writes: > >> lazy_disable framework in OMAP HSMMC manages multiple low power states >> and Card is powered off after inactivity time of 8 seconds. >> Based on previous discussion on the list Card power(regulator) > > needs some punctuation for readability. OK > >> handling (when to power OFF/ON) should ideally be handled by core layer. > > So are you working on the core layer replacement for this? If not, is > there a plan or owner for this? Venkat and myself are planing to start on this for MMC and SD. Some partial work has already been done for SDIO, need to consolidate this for all three of them. > >> Remove usage of lazy disable to allow core layer _only_ to handle card power. >> With the removal of lazy disable framework, MMC regulators >> are left ON until MMC_POWER_OFF via set_ios. >> >> Signed-off-by: Balaji T K <balajitk@xxxxxx> > > [...] > >> @@ -2080,10 +1848,7 @@ static int __init omap_hsmmc_probe(struct platform_device *pdev) >> platform_set_drvdata(pdev, host); >> INIT_WORK(&host->mmc_carddetect_work, omap_hsmmc_detect); >> >> - if (mmc_slot(host).power_saving) >> - mmc->ops = &omap_hsmmc_ps_ops; >> - else >> - mmc->ops = &omap_hsmmc_ops; >> + mmc->ops = &omap_hsmmc_ops; > > I guess the _ps_ops struct is now completely unused so should probably > be removed in this patch also. done -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
