Re: [PATCH 1/3] MMC: Fix checkpatch errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jun 18, 2011 at 07:50:23PM +0200, Sebastian Rasmussen wrote:

Please state in the commit-msg what kind of errors have been fixed.

They all seem to be whitespace related issues. Have you checked that the
binaries are identical before and after your patch? That could also go into the
commit-msg.

> Signed-off-by: Sebastian Rasmussen <sebras@xxxxxxxxx>
> ---
>  drivers/mmc/card/block.c    |   14 ++++++--------
>  drivers/mmc/card/mmc_test.c |   34 +++++++++++++++++-----------------
>  drivers/mmc/card/queue.c    |   14 +++++++-------
>  drivers/mmc/core/core.c     |    2 +-
>  drivers/mmc/core/mmc.c      |    2 +-
>  drivers/mmc/core/mmc_ops.c  |    4 ++--
>  drivers/mmc/core/sd.c       |    2 +-
>  drivers/mmc/core/sd_ops.c   |    4 ++--
>  drivers/mmc/core/sdio.c     |    4 ++--
>  drivers/mmc/core/sdio_bus.c |    2 +-
>  drivers/mmc/core/sdio_cis.c |   18 ++++++++++--------
>  drivers/mmc/core/sdio_ops.h |    2 +-
>  12 files changed, 51 insertions(+), 51 deletions(-)
> 
> diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
> index 71da564..1c7049a 100644
> --- a/drivers/mmc/card/block.c
> +++ b/drivers/mmc/card/block.c
> @@ -908,10 +908,10 @@ static int mmc_blk_issue_rw_rq(struct mmc_queue *mq, struct request *req)
>  	return 1;
>  
>   cmd_err:
> - 	/*
> - 	 * If this is an SD card and we're writing, we can first
> - 	 * mark the known good sectors as ok.
> - 	 *
> +	/*
> +	 * If this is an SD card and we're writing, we can first
> +	 * mark the known good sectors as ok.
> +	 *
>  	 * If the card is not SD, we can still ok written sectors
>  	 * as reported by the controller (which might be less than
>  	 * the real number of written sectors, but never more).
> @@ -1003,8 +1003,7 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
>  	if (!subname) {
>  		md->name_idx = find_first_zero_bit(name_use, max_devices);
>  		__set_bit(md->name_idx, name_use);
> -	}
> -	else
> +	} else

else-block needs braces.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux