Re: [PATCH v3 2/4] mmc: support sdhci-pxav2.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> How about changing the title of the option though? A user will
> usually not know if he is using the v2 or v3 controller without
> reading the help text. If you change it to
>
> config MMC_SDHCI_PXAV2
> Â Â Â Âtristate "Marvell PXA168 SD Host Controller support (PXAV2)"
> Â Â Â Âdefault CPU_PXA168
>
> config MMC_SDHCI_PXAV3
> Â Â Â Âtristate "Marvell MMP2/PX9XX SD Host Controller support (PXAV3)"
> Â Â Â Âdefault CPU_MMP2 || CPU_PXA910
>

Yeah, the above is much cleaner/simpler.

> you increase the chances of users getting the configuration right.
>
> Â Â Â ÂArnd
>
> BTW, both of you: Please always remove the lines that you don't refer to
> when you reply to an email. It's very annoying having to scroll through
> dozens of lines of citations to see what you are actually writing.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux