* T Krishnamoorthy, Balaji <balajitk@xxxxxx> [110531 06:28]: > On Tue, May 31, 2011 at 6:56 PM, Tony Lindgren <tony@xxxxxxxxxxx> wrote: > > * Balaji T K <balajitk@xxxxxx> [110530 07:23]: > >> eMMC does not handle power off when not in sleep state, > >> Skip regulator disable during probe when eMMC is > >> not in known state - state left by bootloader. > >> > >> Resolves eMMC failure on OMAP4 > >> mmc0: error -110 whilst initialising MMC card > >> > >> --- a/arch/arm/mach-omap2/hsmmc.h > >> +++ b/arch/arm/mach-omap2/hsmmc.h > >> @@ -18,6 +18,7 @@ struct omap2_hsmmc_info { > >>    bool  Ânonremovable;  /* Nonremovable e.g. eMMC */ > >>    bool  Âpower_saving;  /* Try to sleep or power off when possible */ > >>    bool  Âno_off;     /* power_saving and power is not to go off */ > >> +   bool  Âno_off_init;  Â/* no power off when not in MMC sleep state */ > >>    bool  Âvcc_aux_disable_is_sleep; /* Regulator off remapped to sleep */ > >>    int   gpio_cd;    Â/* or -EINVAL */ > >>    int   gpio_wp;    Â/* or -EINVAL */ > > > > Can't you use no_off for this too? > > no_off is used for devices which do not want to disable regulator at any time. > > newly introduced no_off_init is to skip disable regulator only during probe > After eMMC is put in sleep state (while suspend), regulator for eMMC > (VAUX1) can be disabled. OK I'll queue this as a fix too then. Anybody from the MMC list care to ack? Tony -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html