Re: Possible bug in sdio.c?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sunday 29 May 2011 07:42 PM, Michał Mirosław wrote:
On Sun, May 29, 2011 at 07:26:00AM +0530, Prashanth Bhat wrote:
Hi Michał,
In mmc/core/sdio.c, routine mmc_enable_4bit_bus():

I think:

     if (card->type == MMC_TYPE_SDIO)
               return sdio_enable_wide(card);

should really be:

     if (card->type == MMC_TYPE_SDIO || card->type == MMC_TYPE_SD_COMBO )
                return sdio_enable_wide(card);

Otherwise, the SDIO component of the SD Combo card will not operate
in wide mode. What do you think?

Perhaps a similar change is needed in the sdio_enable_hs() routine too.
Hi,

You sent similar problem report some time ago. I assumed you will follow
on with a patch fixing mmc_card_sd() and friends (the functions you point
out in this mail should use that).

Best Regards,
Michał Mirosław


Thanks for the reply. Are there other places where this new function must be used? Is it only these 2 places?

Could you please clarify the formal process for including these changes into the build? I have made the previous changes in my private code tree only so far.

Thanks,
Prashanth
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux