Re: [PATCH] dw_mmc: fixed wrong regulator_enable in suspend/resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 12, 2011 at 4:46 AM, Chris Ball <cjb@xxxxxxxxxx> wrote:
> Hi,
>
> On Wed, May 11 2011, Jaehoon Chung wrote:
>> Hi Chris..
>>
>> I think you're confused something because my explanation.
>>
>> My means..if we use the regulator, regulator is enabled when probing.
>> Then regulator is enabling until we don't disable..
>>
>> In order to power-save, disabled the regulator when entered suspend.
>> Already in suspend function, located "regulator_disable()".
>> but also located "regulator_enable()" in suspend function.
>>
>> So i think right that "regulator_enable()" is located in resume function.
>> not in suspend function.
>
> Thanks, I agree.  I hadn't looked at the suspend function, but now I see
> that it already has the disable.
>
> Will, want to ACK this before I merge it?

Looks ok to me, although I don't have suitable hardware to test it.

Acked-by: Will Newton <will.newton@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux