Chris Ball wrote: > Hi Jaehoon, > > On Mon, May 02 2011, Jaehoon Chung wrote: >> Hi Chris.. >> >> Thanks for comments... >> I think that could confuse that message when didn't set CONFIG_REGULATOR. > > The message *does not appear* when CONFIG_REGULATOR is unset, because > NULL -- which the regulator subsystem returns via the regulator_get() > stub -- is not an IS_ERR(). Do you agree? Thanks, I agreed that. I'm interesting mailing's discussion about "[PATCH] pxamci: remove an ifdef about CONFIG_REGULATOR " (in this case, i think similar case) > >> And i wonder how do you think about regulator control in suspend (dw_mmc.c)? > > Yes, that patch looks correct, although I can't test it myself. Please > send it separately. Ok. i will send that separately patch. Regards, Jaehoon Chung -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html