RE: [PATCH v4 00/15] add support for host controller v3.00

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi All,

The patches already have one Tested-by and Reviewed-by from Philip. Would someone else also like to give their approval?

Thanks,
Arindam

> -----Original Message-----
> From: Arindam Nath [mailto:anath.amd@xxxxxxxxx] On Behalf Of Arindam
> Nath
> Sent: Thursday, May 05, 2011 12:19 PM
> To: cjb@xxxxxxxxxx
> Cc: prakity@xxxxxxxxxxx; zhangfei.gao@xxxxxxxxx;
> subhashj@xxxxxxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; Su, Henry; Lu,
> Aaron; anath.amd@xxxxxxxxx; Nath, Arindam
> Subject: [PATCH v4 00/15] add support for host controller v3.00
> 
> V4
> ----
> [01/15]: Move the definition of mmc_set_signal_voltage() from
>          sd_ops.c to core.c so that SDIO and MMC can also make
>          use of it.
> [01/15]: Move mmc_set_signal_voltage(..., MMC_SIGNAL_VOLTAGE_330)
>          before mmc_send_app_op_cond().
> [01/15]: Set 3.3V signaling voltage if ios->signal_voltage is set
>          to MMC_SIGNAL_VOLTAGE_330.
> [01/15]: Provided #defines for SD OCR register bits S18R (bit 24),
>          XPC (bit 28), and CCS (bit 30).
> [08/15]: Enable _only_ Buffer Read Ready interrupt and disable all
>          other interrupts at the begining of sdhci_execute_tuning(),
>          and do the reverse before exiting the function.
> [08/15]: Set the block size to 64 before tuning.
> [08/15]: Make sure Multi Block Select and DMA Enable in the Transfer
>          Mode register are set to 0 before tuning.
> [09/15]: Enable preset value registers _only_ after a successfull
>          UHS-I initialization.
> 
> 
> [12/15]: sdhci pxa add platform specific code for UHS signaling
> [13/15]: mmc eMMC signal voltage does not use CMD11
> [14/15]: sdhci add hooks for UHS setting by platform specific code
> [15/15]: mmc add support for eMMC Dual Data Rate
> 
> V3
> ----
> [01/11]: Set bit 24 and bit 28 of OCR within mmc_sd_get_cid(),
>          and only retry sending ACMD41 with bit 24 reset in case
>          signal voltage switch procedure fails.
> [01/11]: Change (*rocr & 0x41000000) to ((*rocr & 0x41000000) ==
>          0x41000000) to check for both CCS and S18A to be set in
>          the response of ACMD41.
> [01/11]: Change the condition if (err == -EAGAIN) to if (err), in
>          order to retry sending ACMD41 because of any error during
>          signal voltage switch procedure.
> [01/11]: Add a new variable signal_voltage to struct mmc_ios,
>          which holds whether the request is to change to 1.8V or
>          3.3V signalling voltage.
> [02/11]: Remove redundant code to find bus speed modes for SD2.0
>          and SD3.0 cards separately.
> [02/11]: Change the variable names from uhs_* to sd3_* to make
>          them appropriate to the context of their usage.
> [03/11]: Change variable names from *_set_drv_type to *_drv_type.
> [03/11]: Set driver type even when the default driver type B is
>          used.
> [03/11]: Clear bits 05-04 of Host Control 2 register before
>          setting the new driver strength.
> [04/11]: Use sdhci_set_clock() to make sure the clock is stable
>          before re-enabling SD clock.
> [05/11]: Initialize bus_speed and timing to 0 at the beginning of
>          sd_set_bus_speed_mode() to avoid compiler warning.
> [06/11]: Initialize current_limit to 0 to avoid compiler warning.
> [06/11]: Remove usage of get_max_current_180() and replace this
>          with MMC_CAP_MAX_CURRENT_*.
> [06/11]: Set the current limit even for the default current limit
>          of 200mA.
> [06/11]: Set the current limit only for SDR50, SDR104, and DDR50
>          UHS-I modes, otherwise set the default current limit.
> [07/11]: Change mmc_*_ultrahighspeed() to mmc_sd_*_uhs().
> [08/11]: Re-read Host Control 2 register before clearing
>          *_TUNED_CLK and *_EXEC_TUNING.
> [08/11]: Make sdhci_execute_tuning() return 'int' rather than
>          'void' so that we can check for error conditions during
>          tuning failure.
> [08/11]: Make sure to return 0 for controllers which provide
>          support for retuning even if tuning fails. For other
>          controllers, return error code.
> [09/11]: Disable using Preset Value when a new card is inserted,
>          and enable its use only after a successfull UHS-I
>          initializaton.
> [11/11]: Remove sdhci_start_retuning_timer() completely, and start
>          the re-tuning timer from within sdhci_execute_tuning()
>          the very first time it is executed.
> 
> V2
> ----
> [01/12]: Make saved_abort_cmd part of struct sdhci_host rather
>          than global variable.
> [01/12]: Clear SDHCI_USE_SDMA _iff_ SDHCI_USE_ADMA is set.
> [01/12]: Set either Auto CMD23 or Auto CMD12, but not both, in
>          the Transfer Mode register.
> [02/12]: Check host controller version before reading
>          SDHCI_CAPABILITIES_1.
> [02/12]: Remove spinlock from sdhci_start_signal_voltage_switch
>          and use usleep_range() rather than mdelay().
> [02/12]: Set S18R in OCR to 1 for all UHS-I modes.
> [02/12]: NULL pointer check for start_signal_voltage_switch().
> [02/12]: Set MMC_CAP_UHS_SDR50 if MMC_CAP_UHS_SDR104 is set.
> [06/12]: Add checking for SDR25 in sd_set_bus_speed_mode().
> [09/12]: Remove checking for MMC_SEND_TUNING_BLOCK within
>          sdhci_set_transfer_mode(), since cmd.data is set to
>          NULL inside sdhci_execute_tuning().
> [11/12]: Correctly set clk to SDHCI_PROG_CLOCK_MODE when host
>          controller supports Programmable Clock Mode.
> 
> V1
> ----
> The patches below add support for Host Controller v3.00 as per the
> spec v3.00. It also adds support for UHS-I cards as per Physical
> Layer Specification v3.01.
> 
> Thanks for review.
> 
> Regards,
> Arindam
> 
> Arindam Nath (11):
>   [PATCH 01/15] mmc: sd: add support for signal voltage switch
> procedure
>   [PATCH 02/15] mmc: sd: query function modes for uhs cards
>   [PATCH 03/15] mmc: sd: add support for driver type selection
>   [PATCH 04/15] mmc: sdhci: reset sdclk before setting high speed
> enable
>   [PATCH 05/15] mmc: sd: add support for uhs bus speed mode selection
>   [PATCH 06/15] mmc: sd: set current limit for uhs cards
>   [PATCH 07/15] mmc: sd: report correct speed and capacity of uhs cards
>   [PATCH 08/15] mmc: sd: add support for tuning during uhs
> initialization
>   [PATCH 09/15] mmc: sdhci: enable preset value after uhs
> initialization
>   [PATCH 10/15] mmc: sdhci: add support for programmable clock mode
>   [PATCH 11/15] mmc: sdhci: add support for retuning mode 1
> 
> Philip Rakity (4):
>   [PATCH 12/15] sdhci pxa add platform specific code for UHS signaling
>   [PATCH 13/15] mmc eMMC signal voltage does not use CMD11
>   [PATCH 14/15] sdhci add hooks for UHS setting by platform specific
> code
>   [PATCH 15/15] mmc add support for eMMC Dual Data Rate
> 
>  drivers/mmc/core/bus.c       |   11 +-
>  drivers/mmc/core/core.c      |   57 +++-
>  drivers/mmc/core/core.h      |    5 +-
>  drivers/mmc/core/mmc.c       |   35 ++-
>  drivers/mmc/core/sd.c        |  405 ++++++++++++++++++++++--
>  drivers/mmc/core/sd.h        |    3 +-
>  drivers/mmc/core/sdio.c      |    3 +-
>  drivers/mmc/host/sdhci-pxa.c |   36 +++
>  drivers/mmc/host/sdhci.c     |  707
> +++++++++++++++++++++++++++++++++++++++---
>  drivers/mmc/host/sdhci.h     |   47 +++-
>  include/linux/mmc/card.h     |   43 +++
>  include/linux/mmc/host.h     |   37 +++
>  include/linux/mmc/mmc.h      |    1 +
>  include/linux/mmc/sd.h       |    7 +
>  include/linux/mmc/sdhci.h    |   11 +
>  15 files changed, 1307 insertions(+), 101 deletions(-)
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux