Hi Lars, On Sat, Apr 30 2011, Lars-Peter Clausen wrote: > On 04/30/2011 06:35 AM, Chris Ball wrote: >> The regulator subsystem provides stubbed out versions of its calls that >> are always present (so that they can be used without needing #ifdefs). >> But the regulator_get() stub always returns an error value according >> to IS_ERR(), which leads sdhci to print messages like "mmc0: no vmmc >> regulator found" on every boot, even if CONFIG_REGULATOR is not set. >> >> This patch fixes that (and removes the unwanted message) by having >> the regulator_get() call occur inside an #ifdef CONFIG_REGULATOR. > > Shouldn't the stubbed version of regulator_get return NULL, which is not > treated as an error by IS_ERR? Oops, thanks -- you're right, of course. I withdraw the patch. - Chris. -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
