Hi Zhangfei, > -----Original Message----- > From: zhangfei gao [mailto:zhangfei.gao@xxxxxxxxx] > Sent: Thursday, April 28, 2011 10:47 AM > To: Nath, Arindam > Cc: cjb@xxxxxxxxxx; linux-mmc@xxxxxxxxxxxxxxx; prakity@xxxxxxxxxxx; > subhashj@xxxxxxxxxxxxxx; Su, Henry; Lu, Aaron; anath.amd@xxxxxxxxx > Subject: Re: [PATCH v3 09/11] mmc: sdhci: enable preset value after uhs > initialization > > On Wed, Apr 20, 2011 at 5:30 AM, Arindam Nath <arindam.nath@xxxxxxx> > wrote: > > According to the Host Controller spec v3.00, setting Preset Value > Enable > > in the Host Control2 register lets SDCLK Frequency Select, Clock > Generator > > Select and Driver Strength Select to be set automatically by the Host > > Controller based on the UHS-I mode set. This patch enables this > feature. > > We also reset Preset Value Enable next time before initialization. > > > > Signed-off-by: Arindam Nath <arindam.nath@xxxxxxx> > > Hi, Arindam > > This patch cause abnormal behavior of general hs card, since > enable_preset_value(host, 1) is set to both uhs card and general card > here. > Your patch serious basically works with the fix, thanks a lot. > Additional call back to enable external regulator output voltage is > needed on our platform for testing. > > Thanks > > > --- > > drivers/mmc/core/sd.c | 11 +++++++++++ > > drivers/mmc/host/sdhci.c | 32 ++++++++++++++++++++++++++++++++ > > include/linux/mmc/host.h | 1 + > > 3 files changed, 44 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/mmc/core/sd.c b/drivers/mmc/core/sd.c > > index f3ecdef..08305ab 100644 > > --- a/drivers/mmc/core/sd.c > > +++ b/drivers/mmc/core/sd.c > > @@ -959,6 +959,13 @@ static int mmc_sd_init_card(struct mmc_host > *host, u32 ocr, > > } > > } > > > > + /* > > + * Since initialization is now complete, enable preset > > + * value registers. > > + */ > > + if (host->ops->enable_preset_value) > > + host->ops->enable_preset_value(host, 1); > > + > > Could you move this after mmc_sd_card_set_uhs, and only for uhs card. > General hs card may not properly if enable this feature. Yes, that would make sense. Will fix it. Thanks, Arindam -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
