Hi Philip, [...] > >> - if (signal_voltage == MMC_SIGNAL_VOLTAGE_180) { > >> + if (signal_voltage != MMC_SIGNAL_VOLTAGE_330 && cmd11) { > > > > Since we are going to send CMD11 only to change to 1.8V signaling, > and when cmd11 is set, isn't it better to have > > > > if ((signal_voltage == MMC_SIGNAL_VOLTAGE_180) && cmd11) { > > I am okay with this. Wanted to cover the possible future case for 1.2V > support and CMD11. I know eMMC does not do > CMD11 but incase SD or SDIO ever did. If you feel strongly will > change code. If you think that 1.2V might need CMD11, I am okay with your change. Thanks, Arindam -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html