On Wed, 20 Apr 2011, MichaÅ MirosÅaw wrote: > >> I'm okay with the anon union + ``compat_ptr(*(u32 *))`` part of your > >> solution. ÂIf everyone else thinks it is reasonable, I'll submit a v7 > >> with it. > > No need for a union or a ptr_size member in the struct. Just use > > a single __u64 and let the user cast the pointer to that. This > > will work on all architectures. > > Union is just hiding this cast (it will be done in kernel) and allows > cleaner code for userspace (there's a single kernel and possibly > multiple applications that will implement this call). > Chris, Do you have a preference here? I do not have a preference. On the one hand, not having the union makes for a cleaner-to-read struct. On the other hand, not having to cast the pointer in 32-bit userspace is nice especially since I foresee using this ioctl on a lot of ARM SoCs. John
