On Sat, Apr 16, 2011 at 11:19 AM, Nath, Arindam <Arindam.Nath@xxxxxxx> wrote: > Hi Andrei, > Since support for CMD20 and CMD23 have been added in Physical Layer Spec v3.01, IMO it is better to set scr->cmds based on the spec version, rather than doing it unconditionally. Something like, > > + if (scr->sda_vsn == SCR_SPEC_VER_2) { > + /* Check if Physical Layer Spec v3.0 is supported*/ > + scr->sda_spec3 = UNSTUFF_BITS(resp, 47, 1); > + if (scr->sda_spec3) > + scr->cmds = UNSTUFF_BITS(resp, 32, 2); > + } > Sounds good. A -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html