On Thu, Mar 10, 2011 at 9:09 AM, Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Thursday 10 March 2011, Andrei Warkentin wrote: >> >> This allows us to create quirks for block devices, without >> creating messy Kconfig dependencies, or polluting core/ with >> function-specific code. > > The change looks good to me, but it's hard to read because > you are moving around code and changing it in one patch. > > A better split of the first three patches would be to first > move the code to a header file without changing it, and then > make the changes. > > Or you could directly add the code to the header file when you > introduce it in the first patch. So basically squash the three patches dealing with quirks infrastructure? A -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
