Hi, On Wed, Mar 9, 2011 at 3:11 PM, Andrei Warkentin <andreiw@xxxxxxxxxxxx> wrote: >> Does kernel.org still need something to deal with state of >> SDHCI_QUIRK_NO_SDIO_IRQ quirk bit? > > I'm confused. I see this quirk added as part of Tegra sdhci support in > our K36 tree. I suppose with this patch the should be no need for this > quirk. I'll apply your change today and see what I get. Next time, feel free to cc me. :) I removed the quirk during driver cleanup because, based on my testing, it was no longer needed. I also asked nvidia why the quirk was ever needed (took a while to get a response): Turns out it was left over from hardware errata on a previous product using the same IP block (i.e. Tegra 1), and is no longer required for Tegra 2 (since the block gap interrupt is enabled). So, no, it should not be needed in the upstream driver. The patch from Grant is though. If it's unappetizing for sdhci-wide consumption, we could add suspend/resume hooks for sdhci-tegra only and save/restore it there. -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
