Hi,
On Thu, Mar 03 2011, Maxim Levitsky wrote:
> This patch breaks the CONFIG_MMC_UNSAFE_RESUME, because it sets fake
> non-removeable flag, but the intended use of this option is to assume
> that card is not removed _during_ suspend, and it can still be removed
> during normal use.
> With this commit, card removal isn't detected.
I guess we disagree about the semantics of CONFIG_MMC_UNSAFE_RESUME.
The Kconfig text says:
config MMC_UNSAFE_RESUME
bool "Assume MMC/SD cards are non-removable (DANGEROUS)"
which I interpret as meaning that you should set MMC_UNSAFE_RESUME
*if you're using a card that cannot be removed*. If your card *can* be
removed, then it would be extremely foolish to turn on MMC_UNSAFE_RESUME,
because then if someone removed your removable card during suspend and
modified it in another machine before resuming, you'd get massive
filesystem corruption.
What am I missing?
- Chris.
--
Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
