> > > > > +/* Abort type definition in the command register */ > > > > > +#define SDHCI_CMD_ABORTCMD 0xC0 > > > > > > > > Won't that belong into sd.h (unless I misunderstood your last mail)? > > > This is the bit definitions of the ABORTCMD CMD-TYPE on the bit6~7 of > > CMD register. > > > Here is the definition of the CMD register derived from SDHC spec. FYI. > > > D15 D14 D13 D08 D07 D06 D05 D04 > > D03 D02 D01 D00 > > > Rsvd Command Index Command Type Data Present Select Command Index > > Check Enable Command CRC Check Enable Rsvd Response Type Select > > > > Ack, I found that, too. Exactly because it is in the standard, I thought > > this should rather go into sd.h than sdhci-esdhc-imx.c. Would be a > > seperate patch, though. > > > Do you means the sdhci.h file? > I find that the sd.h file doesn't contain the bit definitions stuff of SD HOST CONTROLLER registers. > The sdhci.h file has them, such as: > #define SDHCI_COMMAND 0x0E > #define SDHCI_CMD_RESP_MASK 0x03 > #define SDHCI_CMD_CRC 0x08 > #define SDHCI_CMD_INDEX 0x10 > #define SDHCI_CMD_DATA 0x20 My idea was that it belongs more to the command definitions, thus sd.h. But as long as there is nothing to be solved at core-level sdhci.h might do for now as well. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
