* Tony Lindgren <tony@xxxxxxxxxxx> [110225 12:42]: > * Kishore Kadiyala <kishore.kadiyala@xxxxxx> [110225 09:00]: > > +static int omap_mmc_init(struct omap_hwmod *oh, void *hsmmcinfo) > ... > > > + static int mmc_num; > > + > > + c += mmc_num; > > This does not look right.. So since mmc_num is static, it gets initialized to 0, then increased for each call.. What if you want to intialize controller 1 and 3 but not 2? Also, why do you pass void *hsmmcinfo to the function and then cast it to struct omap2_hsmmc_inf *? Why not pass struct omap2_hsmmc_info * to start with? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
