On Fri, Feb 18, 2011 at 02:37:02PM +0100, Arnd Bergmann wrote: > On Friday 18 February 2011, Sascha Hauer wrote: > > This switches the mxcmmc driver to use the dmaengine API. Unlike > > the old one this one is always present in the tree, even if no DMA > > is implemented, hence we can remove all the #ifdefs in from the driver. > > The driver automatically switches to PIO mode if no DMA support or no > > suitable channel is available. > > > > Signed-off-by: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > The patch looks good to me, but shouldn't you also add a Kconfig > dependency or select on CONFIG_DMA_ENGINE? I don't see where that > gets set. I was about to answer with a patch adding a select on CONFIG_DMA_ENGINE but just realized this isn't necessary. Without dmaengine support dma_request_channel becomes a static inline returning NULL. The mxcmmc driver falls back to PIO then and still works. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
