Begin forwarded message: > From: "Nath, Arindam" <Arindam.Nath@xxxxxxx> > Date: February 16, 2011 10:52:50 PM PST > To: Philip Rakity <prakity@xxxxxxxxxxx> > Cc: "Su, Henry" <Henry.Su@xxxxxxx>, "Lu, Aaron" <Aaron.Lu@xxxxxxx> > Subject: RE: [PATCH 00/12] add support for sd host controller v3.00 > > Good catch Philip. Thanks for the review. I will fix it. BTW, you can put this comment on the community too. > > Thanks, > Arindam > >> -----Original Message----- >> From: Philip Rakity [mailto:prakity@xxxxxxxxxxx] >> Sent: Thursday, February 17, 2011 12:07 PM >> To: Nath, Arindam >> Subject: Re: [PATCH 00/12] add support for sd host controller v3.00 >> >> >> code review >> set_clock >> >> clk is not set to 0 at the start >> >> static void sdhci_set_clock(struct sdhci_host *host, unsigned int >> clock) >> { >> int div = 0; /* Initialized for compiler warning */ >> u16 clk; >> unsigned long timeout; >> >> >> used further on >> >> if (!(ctrl & SDHCI_CTRL_PRESET_VAL_ENABLE)) { >> for (div = 1; div <= 1024; div++) { >> if (((host->max_clk * host->clk_mul) / >> div) <= clock) >> break; >> } >> /* >> * Set Programmable Clock Mode in the Clock >> * Control register. >> */ >> clk |= SDHCI_PROG_CLOCK_MODE; >> div--; >> >> >> and at the end reset >> >> >> clk = (div & SDHCI_DIV_MASK) << SDHCI_DIVIDER_SHIFT; >> clk |= ((div & SDHCI_DIV_HI_MASK) >> SDHCI_DIV_MASK_LEN) >> << SDHCI_DIVIDER_HI_SHIFT; >> >> >> Philip >> >> >> On Feb 16, 2011, at 9:32 PM, Nath, Arindam wrote: >> >>> Please find the file attached. >>> >>> Thanks, >>> Arindam >>> >>>> -----Original Message----- >>>> From: Philip Rakity [mailto:prakity@xxxxxxxxxxx] >>>> Sent: Thursday, February 17, 2011 8:02 AM >>>> To: Nath, Arindam >>>> Subject: Re: [PATCH 00/12] add support for sd host controller v3.00 >>>> >>>> >>>> Don't feel right -- that is why wanted to see the code first ! >>>> >>>> >>>> On Feb 16, 2011, at 6:22 PM, Nath, Arindam wrote: >>>> >>>>> OK Philip, I will send the file from office. BTW, you can go ahead >>>> and post your comments on the community too, if you feel right. >>>>> >>>>> Thanks, >>>>> Arindam >>>>> >>>>>> -----Original Message----- >>>>>> From: Philip Rakity [mailto:prakity@xxxxxxxxxxx] >>>>>> Sent: Thursday, February 17, 2011 7:42 AM >>>>>> To: Nath, Arindam >>>>>> Subject: Re: [PATCH 00/12] add support for sd host controller >> v3.00 >>>>>> >>>>>> >>>>>> Please send sdhci.c I have comments you may want to have for V2 >>>>>> >>>>>> On Feb 16, 2011, at 6:03 PM, Nath, Arindam wrote: >>>>>> >>>>>>> Hi Chris, >>>>>>> >>>>>>>> -----Original Message----- >>>>>>>> From: Chris Ball [mailto:cjb@xxxxxxxxxx] >>>>>>>> Sent: Thursday, February 17, 2011 2:25 AM >>>>>>>> To: Nath, Arindam >>>>>>>> Cc: linux-mmc@xxxxxxxxxxxxxxx; Su, Henry; Lu, Aaron; >>>>>>>> anath.amd@xxxxxxxxx >>>>>>>> Subject: Re: [PATCH 00/12] add support for sd host controller >>>> v3.00 >>>>>>>> >>>>>>>> Hi Arindam, >>>>>>>> >>>>>>>> On Tue, Feb 15, 2011 at 03:04:58PM +0530, Arindam Nath wrote: >>>>>>>>> The patches below add support for Host Controller v3.00 as per >>>> the >>>>>>>>> spec v3.00. It also adds support for UHS-I cards as per >> Physical >>>>>>>>> Layer Specification v3.01. >>>>>>>> >>>>>>>> Could you base v2 of the patchset on top of my mmc-next branch¹, >>>>>>>> please? >>>>>>>> I'm not sure what v1 was prepared against, but patch [2/12] >>>> onwards >>>>>>>> don't apply successfully here. >>>>>>> >>>>>>> My patches have been created against Linus' git tree. I will make >>>>>> sure to rebase it against mmc-next for V2. Thanks for the >> patience. >>>>>>> >>>>>>> Regards, >>>>>>> Arindam >>>>>>> >>>>>>> -- >>>>>>> To unsubscribe from this list: send the line "unsubscribe linux- >>>> mmc" >>>>>> in >>>>>>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>>>>>> More majordomo info at http://vger.kernel.org/majordomo- >> info.html >>>>>> >>>>> >>>>> >>>> >>> >>> <sdhci.c> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
