On Sun, Feb 13, 2011 at 11:35:54PM +0100, Arnd Bergmann wrote: > On Sunday 13 February 2011, Chris Ball wrote: > > On Mon, Feb 14, 2011 at 10:32:20AM +0800, Shawn Guo wrote: > > > This adds the mmc host driver for Freescale MXS-based SoC i.MX23/28. > > > The driver calls into mxs-dma via generic dmaengine api for both pio > > > and data transfer. > > > > > > Signed-off-by: Shawn Guo <shawn.guo@xxxxxxxxxxxxx> > > > > Please add a Reviewed-by: from Arnd and a Tested-by: from Lothar. > > Could you add a MODULE_AUTHOR() field, too? > > In general, these tags should not simply be added by the author without > having the person who did the reviewing or testing specifically provide > them! > > In this particular case, I'm happy with the driver in version 2, good job! > Please do add my > > Reviewed-by: Arnd Bergmann <arnd@xxxxxxxx> > Will do. Appreciate the review effort. Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
