Hi Kevin,
On Wed, Feb 9, 2011 at 4:00 AM, Kevin Hilman <khilman@xxxxxx> wrote:
> Kishore Kadiyala <kishore.kadiyala@xxxxxx> writes:
>
>> From: Paul Walmsley <paul@xxxxxxxxx>
>>
>> Update the omap3 hwmod data with the HSMMC info.
>>
>> Signed-off-by: Paul Walmsley <paul@xxxxxxxxx>
>> Signed-off-by: Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Rajendra Nayak <rnayak@xxxxxx>
>> Signed-off-by: Kishore Kadiyala <kishore.kadiyala@xxxxxx>
>
> [...]
>
> Just notcied a minor issue below, which was probably inherited from my
> original hacks on this code...
>
>> +static struct omap_hwmod omap3xxx_mmc1_hwmod = {
>> + .name = "mmc1_hwmod",
>> + .mpu_irqs = mmc1_mpu_irqs,
>> + .mpu_irqs_cnt = ARRAY_SIZE(mmc1_mpu_irqs),
>> + .sdma_reqs = mmc1_sdma_reqs,
>> + .sdma_reqs_cnt = ARRAY_SIZE(mmc1_sdma_reqs),
>> + .opt_clks = mmc1_opt_clks,
>> + .opt_clks_cnt = ARRAY_SIZE(mmc1_opt_clks),
>> + .main_clk = "mmchs1_fck",
>> + .prcm = {
>> + .omap2 = {
>> + .module_offs = CORE_MOD,
>> + .prcm_reg_id = 1,
>> + .module_bit = OMAP3430_GRPSEL_MMC1_SHIFT,
>
> Thee GRPSEL bit isn't the right bit here, and should be the
> EN_MMC1_SHIFT value. I realize, they're probably the same bitfield, but
> this should be consistent with the other hwmods.
OK, I will make changes as mentioned in omap_hwmod_3xxx_data.c.
>
> Same issue with other MMC hwmods.
The rest of the hwmods for MMC are updated with *EN_MMC* .
Regards,
Kishore
>
> Kevin
>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
