Hi Chris, Am 05.01.2011 22:22, schrieb Chris Ball: > Hi Arnd, > > On Wed, Dec 29, 2010 at 02:21:13PM +0100, Arnd Hannemann wrote: >> This patch addresses this problem by introducing timeouts for outstanding >> interrupts. If a hardware interrupt is missing, a soft reset will be performed >> to bring the hardware back to a working state. >> Tested with the SDHI hardware block in sh7372 / AP4EVB. >> >> Signed-off-by: Arnd Hannemann <arnd@xxxxxxxxxx> > > This breaks compilation without CONFIG_TMIO_MMC_DMA=y, because it > attempts to compile tmio_mmc_reset_work() unconditionally even though > delayed_reset_work is only a member of tmio_mmc_host if TMIO_MMC_DMA=y: > > drivers/mmc/host/tmio_mmc.c: In function âtmio_mmc_reset_workâ: > drivers/mmc/host/tmio_mmc.c:357:31: error: âstruct tmio_mmc_hostâ has no member named âdelayed_reset_workâ Hmm, I could not reproduce this. delayed_reset_work should not be in the #ifdef TMIO_MMC_DMA #endif scope. And it isn't according to the patch. I tried with mmc-next last commit "549bad416ef62f09711cb22e77adff029e27ce07". The patch would apply with some fuzz, but compilation without CONFIG_TMIO_MMC_DMA=y works. With what tree and .config did you try? Maybe I confused you with my email mentioning the older patches, did you try the (rebased) v2: https://patchwork.kernel.org/patch/439421/ https://patchwork.kernel.org/patch/439431/ Thanks Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
