Hi Guennadi, On Wed, Jan 05, 2011 at 10:09:42PM +0100, Guennadi Liakhovetski wrote: > > - pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! 0x%04x 0x%04x 0x%04x\n", > > - sdio_status, sdio_irq_mask, sdio_ireg); > > + pr_warning("tmio_mmc: Spurious SDIO IRQ, disabling! " > > + "0x%04x 0x%04x 0x%04x\n", > > + sdio_status, sdio_irq_mask, sdio_ireg); > > Don't think this is a good idea. 80-columns restriction stopped being a > requirement since some time, and - it has always been explicitly requested > _not_ to break strings in prints because of this. Yes, it is not very > likely, that someone will grep for "IRQ.*\%" or similar, still, I would > prefer to keep the original version. Okay, I'll use the original version of the pr_warning(). Thanks, -- Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> One Laptop Per Child -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html