On Wed, Jan 5, 2011 at 12:34 AM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote: > On Wed, Jan 5, 2011 at 1:25 AM, Pierre Tardy <tardyp@xxxxxxxxx> wrote: >> There is no such platform data in intel_mid platforms.. Sound like >> another platform hack will be needed for wl1271 to be integrated. :-( > > John (cc'ed) ported this to your platform and can share the solution > with you; IIRC the idea was the same: identify the card according to > the slot id (this is reasonable because the card is nonremovable) and > set it as MMC_QUIRK_NONSTD_FUNC_IF. Well, we dont do it like this in intel_mid. Every platform quirk has to come somehow from the firmware (SFI), and there is no such descriptor to my knowledge. Lets see what John is proposing... >> Our first idea to resolve this problem was to hardcode wl1273 vendor >> id/product id in a black list table near read_fbr... > > I'm not sure we want to hardcode such details in the SDIO core itself > (think of how it would look if more devices will show up..). Yes, that's why I thought of a table, we might want to make this more generic, and, as you are proposing more than one quirk those few days for cards, we could add those quirks in struct sdio_device_id, like they do for PCI... The thing is that the semantic of your solution is wrong. You want to say: Hey! wl1271 is broken and you actually say: Hey! the card in slot named "external" of omap4 zoom is brocken. Regards, Pierre -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
