On 04/01/2011 22:27, Ohad Ben-Cohen wrote: > On Wed, Jan 5, 2011 at 12:13 AM, Ohad Ben-Cohen <ohad@xxxxxxxxxx> wrote: >>> Whether this pull up should be >>> enabled or disabled is determined by the board (not the card). The >>> pull-up should be disabled if the board has a pull-up external to the >>> card, otherwise it must remain enabled. >> >> Agree. > > It might make more sense to use a host CAP though for this (i.e. > MMC_CAP_DISABLE_CD). Could we unconditionally disable the card's internal pull-up? A board that's using DAT3 for card detection should have a switchable pull-down /and/ a switchable pull-up. This would cause regressions on boards that aren't properly designed and have omitted the pull-up. Are there boards like this? David -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html