Re: [PATCH 3/3] mmc: add sdhci-tegra driver for Tegra SoCs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Dec 22, 2010 at 10:20 PM, Mike Rapoport <mike@xxxxxxxxxxxxxx> wrote:

> Only one comment below, otherwise feel free to add
> Acked-by: Mike Rapoport <mike@xxxxxxxxxxxxxx>

Thanks!

>> +     if (gpio_is_valid(plat->wp_gpio)) {
>> +             rc = gpio_request(plat->wp_gpio, "sdhci_wp");
>> +             if (rc) {
>> +                     dev_err(mmc_dev(host->mmc),
>> +                             "failed to allocate wp gpio\n");
>> +                     goto out_cd;
>> +             }
>> +             tegra_gpio_enable(plat->wp_gpio);
>
> gpio_direction_input?

Yep, for cd_gpio too.


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux