On Thu, Dec 02, 2010 at 02:36:58PM +0100, Linus Walleij wrote:
> The regulator and MMC frameworks provide the proper stub functions
> for the regulator functions anyway, get rid of this.
I'm dropping this patch - it's wrong, because on platforms without
regulator support, it stamps over the provided platform values:
mmci-pl18x mb:mmci: Provided ocr_mask/setpower will not be used (using regulator instead)
# CONFIG_REGULATOR is not set
So the ifdefs have to stay until some other solution for this is found.
Maybe the:
if (IS_ERR(host->vcc))
host->vcc = NULL;
else {
should be:
if (IS_ERR(host->vcc) || host->vcc == NULL)
host->vcc = NULL;
else {
or maybe:
if (IS_ERR(host->vcc))
host->vcc = NULL;
else if (host->vcc) {
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
