> -----Original Message----- > From: Arnd Bergmann [mailto:arnd@xxxxxxxx] > Sent: Monday, December 06, 2010 8:29 PM > To: Dong, Chuanxiao > Cc: linux-mmc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; cjb@xxxxxxxxxx; > akpm@xxxxxxxxxxxxxxxxxxxx; arjan@xxxxxxxxxxxxxxx; alan@xxxxxxxxxxxxxxx; > kmpark@xxxxxxxxxxxxx > Subject: Re: [PATCH v2 1/4]enable background operations for supported eMMC > card > > On Friday 03 December 2010, Chuanxiao Dong wrote: > > From 984adc755cf2f7966a89e510a50f085e314fe347 Mon Sep 17 00:00:00 2001 > > From: Chuanxiao Dong <chuanxiao.dong@xxxxxxxxx> > > Date: Mon, 22 Nov 2010 16:31:12 +0800 > > Subject: [PATCH 1/4] mmc: Enabled background operations feature if eMMC card > supports > > These headers don't belong into a submission. If you use git-send-email, > they get cut off automatically, otherwise just remove them as you paste > the patch into your mail client. > OK. I will remove them when the next submission. > > Background operations is a new feature defined in eMMC4.41 standard. > > Since this feature is opertional for eMMC card, so driver only enable > > s/opertional/optional/ > > @@ -54,6 +54,8 @@ struct mmc_ext_csd { > > unsigned int sec_trim_mult; /* Secure trim multiplier */ > > unsigned int sec_erase_mult; /* Secure erase multiplier */ > > unsigned int trim_timeout; /* In milliseconds */ > > + unsigned int bkops:1; /* background support bit */ > > + unsigned int bkops_en:1; /* background enable bit */ > > }; > > Bit fields are not encouraged for kernel internal data structures, > just use "bool" variables here. Thanks Arnd. I will fix this. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
